]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
irqchip/gic-v3-its: Correctly fish out the DID for platform MSI
authorMarc Zyngier <maz@kernel.org>
Thu, 18 Jul 2024 07:58:04 +0000 (08:58 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 18 Jul 2024 18:34:46 +0000 (20:34 +0200)
Similarly to PCI where msi-map/msi-mask are used to compute the full RID
(aka DID in ITS speak), use the msi-parent as the discovery mechanism,
since there is no way a device can generally express its ID.

However, since switching to a per-device MSI domain model, the domain
passed to its_pmsi_prepare() is the wrong one, and points to the device's
instead of the ITS'. Bad.

Use the parent domain instead, which is the ITS domain.

Fixes: 80b63cc1cc146 ("irqchip/gic-v3-its: Switch platform MSI to MSI parent")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240718075804.2245733-1-maz@kernel.org
drivers/irqchip/irq-gic-v3-its-msi-parent.c

index 2f3fc597331ba51e163358a26eecacc604cfa6bd..e150365fbe8922e402ce23d334689093c2301a87 100644 (file)
@@ -134,7 +134,7 @@ static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev,
        int ret;
 
        if (dev->of_node)
-               ret = of_pmsi_get_dev_id(domain, dev, &dev_id);
+               ret = of_pmsi_get_dev_id(domain->parent, dev, &dev_id);
        else
                ret = iort_pmsi_get_dev_id(dev, &dev_id);
        if (ret)