]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: ov5693: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:57 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./i2c/ov5693.c:1296:9-16: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov5693.c

index d294477f9dd30704d2e43a0ed3e222aff3af365f..4cc796bbee9263c032384d8327961b5cee52b9e7 100644 (file)
@@ -1292,8 +1292,8 @@ static int ov5693_probe(struct i2c_client *client)
        ov5693->xvclk = devm_v4l2_sensor_clk_get(&client->dev, "xvclk");
        if (IS_ERR(ov5693->xvclk))
                return dev_err_probe(&client->dev, PTR_ERR(ov5693->xvclk),
-                                    "failed to get xvclk: %ld\n",
-                                    PTR_ERR(ov5693->xvclk));
+                                    "failed to get xvclk: %pe\n",
+                                    ov5693->xvclk);
 
        xvclk_rate = clk_get_rate(ov5693->xvclk);
        if (xvclk_rate != OV5693_XVCLK_FREQ)