clang-tidy: use references

Found with performance-unnecessary-copy-initialization

Signed-off-by: Rosen Penev <rosenp@gmail.com>

diff --git a/pdns/dnssecsigner.cc b/pdns/dnssecsigner.cc
index 27a12a3f402aa7f262e1ce5cb69d87a46845d4a2..a98acf72959fc733a80fc0d9752aaaa9f7892d7b 100644 (file)
--- a/pdns/dnssecsigner.cc
+++ b/pdns/dnssecsigner.cc
@@ -57,7 +57,7 @@ static void fillOutRRSIG(DNSSECPrivateKey& dpk, const DNSName& signQName, RRSIGR
     g_signatureCount = S.getPointer("signatures");
 
   DNSKEYRecordContent drc = dpk.getDNSKEY();
-  const std::shared_ptr<DNSCryptoKeyEngine> rc = dpk.getKey();
+  const std::shared_ptr<DNSCryptoKeyEngine>& rc = dpk.getKey();
   rrc.d_tag = drc.getTag();
   rrc.d_algorithm = drc.d_algorithm;
 

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 4a6dc98262cfc7f7d1a04faefb426b91f28adc13..19eb368a8e9e28da9ebbe8306335d16b556eb21d 100644 (file)
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -582,8 +582,8 @@ static int checkZone(DNSSECKeeper &dk, UeberBackend &B, const DNSName& zone, con
   }
 
   for (const auto &svcb : svcbTargets) {
-    auto name = std::get<0>(svcb);
-    auto target = std::get<2>(svcb);
+    const auto& name = std::get<0>(svcb);
+    const auto& target = std::get<2>(svcb);
     auto prio = std::get<1>(svcb);
 
     if (name == target) {
@@ -606,8 +606,8 @@ static int checkZone(DNSSECKeeper &dk, UeberBackend &B, const DNSName& zone, con
   }
 
   for (const auto &httpsRecord : httpsTargets) {
-    auto name = std::get<0>(httpsRecord);
-    auto target = std::get<2>(httpsRecord);
+    const auto& name = std::get<0>(httpsRecord);
+    const auto& target = std::get<2>(httpsRecord);
     auto prio = std::get<1>(httpsRecord);
 
     if (name == target) {

diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index e7d6692bbc4de01989fd23b459948d29841b7014..be8f089fc6910f5e37a9d8900ceca1dad56cbc3f 100644 (file)
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -756,7 +756,7 @@ void CommunicatorClass::addSlaveCheckRequest(const DomainInfo& di, const ComboAd
 void CommunicatorClass::addTrySuperMasterRequest(const DNSPacket& p)
 {
   std::lock_guard<std::mutex> l(d_lock);
-  DNSPacket ours = p;
+  const DNSPacket& ours = p;
   if(d_potentialsupermasters.insert(ours).second)
     d_any_sem.post(); // kick the loop!
 }

diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index 3871f34d35a7867005a910aa792e91f3b2edc512..1a136da98232fec8306ee51dc0bd766b4220847f 100644 (file)
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -1658,7 +1658,7 @@ static void apiServerZones(HttpRequest* req, HttpResponse* resp) {
 
     // create NS records if nameservers are given
     for (auto value : nameservers.array_items()) {
-      string nameserver = value.string_value();
+      const string& nameserver = value.string_value();
       if (nameserver.empty())
         throw ApiException("Nameservers must be non-empty strings");
       if (!isCanonical(nameserver))