ci: make Perforce binaries executable for all users

The Perforce binaries are only made executable for the current user. On
GitLab CI though we execute tests as a different user than "root", and
thus these binaries may not be executable by that test user at all. This
has gone unnoticed so far because those binaries are optional -- in case
they don't exist we simply skip over tests requiring them.

Fix the setup so that we set the executable bits for all users.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index e673797115f76a8f9471e4a9f0d31fef547546fd..0b9bb686d8c17d08f323203bcb963810373054af 100755 (executable)
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -47,7 +47,7 @@ ubuntu-*)
        mkdir --parents "$CUSTOM_PATH"
        wget --quiet --directory-prefix="$CUSTOM_PATH" \
                "$P4WHENCE/bin.linux26x86_64/p4d" "$P4WHENCE/bin.linux26x86_64/p4"
-       chmod u+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
+       chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
 
        wget --quiet "$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz"
        tar -xzf "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" \