* src/arscan.c (ar_scan): Avoid sign comparison warnings

Pacify 12.2.1 20220819 (Red Hat 12.2.1-2) -Wsign-compare by checking
the readbuf() return explicitly for errors then casting from ssize_t.
Initial patch provided by Paul Eggert <eggert@cs.ucla.edu>.

diff --git a/src/arscan.c b/src/arscan.c
index eb806a6963d6b0e7ef022ee47fbb6496c27f8945..b7180ba226e18fc3613b196b5cc9dbc4fbe156e9 100644 (file)
--- a/src/arscan.c
+++ b/src/arscan.c
@@ -716,12 +716,12 @@ ar_scan (const char *archive, ar_member_func_t function, const void *arg)
               const char* err;
               unsigned int name_len = make_toui (name + 3, &err);
 
-              if (err || name_len == 0 || name_len > PATH_MAX)
+              if (err || name_len == 0 || name_len >= MIN (PATH_MAX, INT_MAX))
                 goto invalid;
 
               name = alloca (name_len + 1);
               nread = readbuf (desc, name, name_len);
-              if (nread != name_len)
+              if (nread < 0 || (unsigned int) nread != name_len)
                 goto invalid;
 
               name[name_len] = '\0';