]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu/gfx12: Add fw minimum version check for usermode queue
authorArvind Yadav <Arvind.Yadav@amd.com>
Wed, 9 Apr 2025 10:15:34 +0000 (15:45 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 22 Apr 2025 12:51:46 +0000 (08:51 -0400)
This patch is load usermode queue based on FW support for gfx12.
CP Ucode FW Vesion: [PFP = 2840, ME = 2780, MEC = 3050, MES = 123]

v2: Addressed review comments from Alex
   - Just check the firmware versions directly.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: Sunil Khatri <sunil.khatri@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Sunil Khatri <sunil.khatri@amd.com>
Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c

index 9cfe50016dab771cc8f2b11d26947dba520fad09..dfa0830a4eb12809059c2e2df695e6510af6d66d 100644 (file)
@@ -1417,8 +1417,11 @@ static int gfx_v12_0_sw_init(struct amdgpu_ip_block *ip_block)
        case IP_VERSION(12, 0, 0):
        case IP_VERSION(12, 0, 1):
 #ifdef CONFIG_DRM_AMDGPU_NAVI3X_USERQ
-               /* add firmware version checks here */
-               if (0 && !adev->gfx.disable_uq) {
+               if (!adev->gfx.disable_uq &&
+                   adev->gfx.me_fw_version  >= 2780 &&
+                   adev->gfx.pfp_fw_version >= 2840 &&
+                   adev->gfx.mec_fw_version >= 3050 &&
+                   adev->mes.fw_version[0] >= 123) {
                        adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
                        adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;
                }