]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
fix parenthesis in pager.c (#5798)
authorMatija Skala <mskala@gmx.com>
Tue, 25 Apr 2017 12:44:29 +0000 (14:44 +0200)
committerLennart Poettering <lennart@poettering.net>
Tue, 25 Apr 2017 12:44:29 +0000 (14:44 +0200)
- result of dup2 should be compared against 0
- making parenthesis around comparisons just to be sure

src/shared/pager.c

index 2501a53c1998fac408b9db9b83b7e2018ba4a39e..22d7603ec69be3fa788d51d264c24e3fee435f5d 100644 (file)
@@ -176,11 +176,11 @@ void pager_close(void) {
 
         /* Inform pager that we are done */
         (void) fflush(stdout);
-        if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0)
+        if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0)))
                 (void) close(STDOUT_FILENO);
         stored_stdout = safe_close(stored_stdout);
         (void) fflush(stderr);
-        if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0)
+        if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0)))
                 (void) close(STDERR_FILENO);
         stored_stderr = safe_close(stored_stderr);
         stdout_redirected = stderr_redirected = false;