]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iscsi_ibft: Fix missing break in switch statement
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 11 Feb 2019 18:43:23 +0000 (12:43 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Mar 2019 21:04:18 +0000 (14:04 -0700)
commit df997abeebadaa4824271009e2d2b526a70a11cb upstream.

Add missing break statement in order to prevent the code from falling
through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/iscsi_ibft.c

index 6bc8e6640d713eb890feb37b95083b1303f364a5..c51462f5aa1e4f52d01cb7c88db42bdc006f7767 100644 (file)
@@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type)
        case ISCSI_BOOT_TGT_NIC_ASSOC:
        case ISCSI_BOOT_TGT_CHAP_TYPE:
                rc = S_IRUGO;
+               break;
        case ISCSI_BOOT_TGT_NAME:
                if (tgt->tgt_name_len)
                        rc = S_IRUGO;