wifi: mwifiex: prefer strscpy() over strlcpy()

Prefer 'strscpy()' over 'strlcpy()' in 'mwifiex_init_hw_fw()'.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230629085115.180499-1-dmantipov@yandex.ru

diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
index 1cd9d20cca16eee2a0b1a3e325e83f3e0fe6f128..d99127dc466ecb767c12424cf6ae0d37ae2d56b4 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/main.c
+++ b/drivers/net/wireless/marvell/mwifiex/main.c
@@ -724,14 +724,9 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter,
        /* Override default firmware with manufacturing one if
         * manufacturing mode is enabled
         */
-       if (mfg_mode) {
-               if (strlcpy(adapter->fw_name, MFG_FIRMWARE,
-                           sizeof(adapter->fw_name)) >=
-                           sizeof(adapter->fw_name)) {
-                       pr_err("%s: fw_name too long!\n", __func__);
-                       return -1;
-               }
-       }
+       if (mfg_mode)
+               strscpy(adapter->fw_name, MFG_FIRMWARE,
+                       sizeof(adapter->fw_name));
 
        if (req_fw_nowait) {
                ret = request_firmware_nowait(THIS_MODULE, 1, adapter->fw_name,