]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sh: kprobes: Remove unneeded kprobe_opcode_t casts
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 1 Mar 2024 21:02:32 +0000 (22:02 +0100)
committerJohn Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Thu, 2 May 2024 10:01:25 +0000 (12:01 +0200)
There is no need to cast a kprobe_opcode_t pointer to a kprobe_opcode_t
pointer.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Link: https://lore.kernel.org/r/fc22b990d869fc2005990159d8072ae2774b1396.1709326528.git.geert+renesas@glider.be
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
arch/sh/kernel/kprobes.c

index d8c2e399d6e50794c26fb8bcff4a61ec99a3d5b7..49c4ffd782d6d6c583dd4de1f4021898fc303381 100644 (file)
@@ -39,7 +39,7 @@ static DEFINE_PER_CPU(struct kprobe, saved_next_opcode2);
 
 int __kprobes arch_prepare_kprobe(struct kprobe *p)
 {
-       kprobe_opcode_t opcode = *(kprobe_opcode_t *) (p->addr);
+       kprobe_opcode_t opcode = *p->addr;
 
        if (OPCODE_RTE(opcode))
                return -EFAULT; /* Bad breakpoint */
@@ -248,7 +248,7 @@ static int __kprobes kprobe_handler(struct pt_regs *regs)
        p = get_kprobe(addr);
        if (!p) {
                /* Not one of ours: let kernel handle it */
-               if (*(kprobe_opcode_t *)addr != BREAKPOINT_INSTRUCTION) {
+               if (*addr != BREAKPOINT_INSTRUCTION) {
                        /*
                         * The breakpoint instruction was removed right
                         * after we hit it. Another cpu has removed