Nest: Fix recursive route update

Missing cleanup can lead to dangling pointer to old next hops.

diff --git a/nest/rt-table.c b/nest/rt-table.c
index b55bcd40d9b5cd6a383106d6d09d5d03c380d353..97a5d1bc798ced372ac1ff06c32a93319a75c8ce 100644 (file)
--- a/nest/rt-table.c
+++ b/nest/rt-table.c
@@ -2109,9 +2109,10 @@ no_nexthop:
     else
     {
       nhr = nhp;
-      nhp = (nhp ? (nhp->next = lp_allocz(rte_update_pool, NEXTHOP_MAX_SIZE)) : &(a->nh));
+      nhp = (nhp ? (nhp->next = lp_alloc(rte_update_pool, NEXTHOP_MAX_SIZE)) : &(a->nh));
     }
 
+    memset(nhp, 0, NEXTHOP_MAX_SIZE);
     nhp->iface = nh->iface;
     nhp->weight = nh->weight;
     if (mls)