]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: fsl: cpm1: qmc: Set the ret error code on platform_get_irq() failure
authorHerve Codina <herve.codina@bootlin.com>
Tue, 5 Nov 2024 14:56:23 +0000 (15:56 +0100)
committerChristophe Leroy <christophe.leroy@csgroup.eu>
Thu, 14 Nov 2024 07:26:15 +0000 (08:26 +0100)
A kernel test robot detected a missing error code:
   qmc.c:1942 qmc_probe() warn: missing error code 'ret'

Indeed, the error returned by platform_get_irq() is checked and the
operation is aborted in case of failure but the ret error code is
not set in that case.

Set the ret error code.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20241105145623.401528-1-herve.codina@bootlin.com
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
drivers/soc/fsl/qe/qmc.c

index 3dffebb48b0daced840746c1a77503b9f94540de..fa7dc7d4abf3da706cc902bb2b060b29e6bfcc3d 100644 (file)
@@ -2005,8 +2005,10 @@ static int qmc_probe(struct platform_device *pdev)
 
        /* Set the irq handler */
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0)
+       if (irq < 0) {
+               ret = irq;
                goto err_exit_xcc;
+       }
        ret = devm_request_irq(qmc->dev, irq, qmc_irq_handler, 0, "qmc", qmc);
        if (ret < 0)
                goto err_exit_xcc;