]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
json-c: Don't build unneeded apps to unblock builds with CMake 4+
authorMoritz Haase <Moritz.Haase@bmw.de>
Mon, 23 Jun 2025 09:56:01 +0000 (11:56 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 26 Jun 2025 08:51:33 +0000 (09:51 +0100)
Disable build of the apps, as we don't seem to package them (upstream says they
aren't ready, see [0]). They are the only part of the code that doesn't build
yet with CMake 4+. One alternative would be to apply [1], but the PR hasn't been
merged yet by upstream, so we keep it simple.

[0]: https://github.com/json-c/json-c/blob/7cee5237dc6c0831e3f9dc490394eaea44636861/apps/CMakeLists.txt#L119-L121
[1]: https://github.com/json-c/json-c/pull/888

Signed-off-by: Moritz Haase <Moritz.Haase@bmw.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/json-c/json-c_0.18.bb

index 2fd1897ba87cc98d4707f09e1e4aaa23300efe05..ece320d66ce1f03ce0c8655374c02c283a9364dd 100644 (file)
@@ -19,8 +19,11 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+)-\d+"
 
 RPROVIDES:${PN} = "libjson"
 
-# Required for ICECC builds
-EXTRA_OECMAKE = "-DDISABLE_WERROR=ON"
+# - '-Werror' must be disabled for ICECC builds
+# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+.
+EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \
+                 -DBUILD_APPS=OFF \
+"
 
 inherit cmake ptest