]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
proto: Fix wrong token in proto_icmp6
authorPhil Sutter <phil@nwl.cc>
Sat, 5 May 2018 12:44:26 +0000 (14:44 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sun, 6 May 2018 20:56:23 +0000 (22:56 +0200)
'token' value of ICMP6HDR_MTU field must be 'mtu', not 'packet-too-big'.
This went unnoticed because rule delinearization for icmp/icmpv6 payload
expressions is problematic anyway in that different fields point to the
same offset and therefore are indistinguishable. In this case, an
expression like e.g. 'icmpv6 mtu 1500' will be printed later as 'icmpv6
parameter-problem 1500'.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/proto.c

index 8cf29d2014dce53b9051556e52cfe279b43139a1..ed011efab22294ba6920e855b49b0db9e064f433 100644 (file)
@@ -689,7 +689,7 @@ const struct proto_desc proto_icmp6 = {
                [ICMP6HDR_CODE]         = ICMP6HDR_FIELD("code", icmp6_code),
                [ICMP6HDR_CHECKSUM]     = ICMP6HDR_FIELD("checksum", icmp6_cksum),
                [ICMP6HDR_PPTR]         = ICMP6HDR_FIELD("parameter-problem", icmp6_pptr),
-               [ICMP6HDR_MTU]          = ICMP6HDR_FIELD("packet-too-big", icmp6_mtu),
+               [ICMP6HDR_MTU]          = ICMP6HDR_FIELD("mtu", icmp6_mtu),
                [ICMP6HDR_ID]           = ICMP6HDR_FIELD("id", icmp6_id),
                [ICMP6HDR_SEQ]          = ICMP6HDR_FIELD("sequence", icmp6_seq),
                [ICMP6HDR_MAXDELAY]     = ICMP6HDR_FIELD("max-delay", icmp6_maxdelay),