]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MAJOR: http: null-terminate the http actions keywords list
authorWilly Tarreau <w@1wt.eu>
Fri, 3 Apr 2015 07:52:01 +0000 (09:52 +0200)
committerWilly Tarreau <w@1wt.eu>
Fri, 3 Apr 2015 07:58:02 +0000 (09:58 +0200)
Commit a0dc23f ("MEDIUM: http: implement http-request set-{method,path,query,uri}")
forgot to null-terminate the list, resulting in crashes when these actions
are used if the platform doesn't pad the struct with nulls.

Thanks to Gunay Arslan for reporting a detailed trace showing the
origin of this bug.

No backport to 1.5 is needed.

src/proto_http.c

index d1cd042a15134949eb8a88b9025eb47eb2c8e1cd..90176fc853228402d1b94e19cde3620124a58a33 100644 (file)
@@ -12033,6 +12033,7 @@ struct http_req_action_kw_list http_req_actions = {
                { "set-path",   parse_set_req_line },
                { "set-query",  parse_set_req_line },
                { "set-uri",    parse_set_req_line },
+               { NULL, NULL }
        }
 };