]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
tool_cb_hdr: Fix etag warning output and return code
authorJay Satiro <raysatiro@yahoo.com>
Fri, 26 Jun 2020 06:26:41 +0000 (02:26 -0400)
committerJay Satiro <raysatiro@yahoo.com>
Fri, 26 Jun 2020 13:48:58 +0000 (09:48 -0400)
- Return 'failure' on failure, to follow the existing style.

- Put Warning: and the warning message on the same line.

Ref: https://github.com/curl/curl/issues/5610

Closes https://github.com/curl/curl/pull/5612

src/tool_cb_hdr.c

index b80707fde57223841bf4b583ee52fb069cc2098a..5741f0abac3e7f524fb822424554c308235f96e1 100644 (file)
@@ -119,8 +119,8 @@ size_t tool_header_cb(char *ptr, size_t size, size_t nmemb, void *userdata)
 
       if(!first) {
         warnf(per->config->global,
-              "\nReceived header etag is missing double quote/s\n");
-        return 1;
+              "Received header etag is missing double quote/s\n");
+        return failure;
       }
       else {
         /* discard first double quote */
@@ -132,8 +132,8 @@ size_t tool_header_cb(char *ptr, size_t size, size_t nmemb, void *userdata)
 
       if(!last) {
         warnf(per->config->global,
-              "\nReceived header etag is missing double quote/s\n");
-        return 1;
+              "Received header etag is missing double quote/s\n");
+        return failure;
       }
 
       /* get length of desired etag */