]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t5330: remove run_with_limited_processses()
authorHan Xin <hanxin.hx@bytedance.com>
Tue, 12 Jul 2022 08:01:43 +0000 (16:01 +0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 12 Jul 2022 14:47:43 +0000 (07:47 -0700)
run_with_limited_processses() is used to end the loop faster when an
infinite loop happen. But "ulimit" is tied to the entire development
station, and the test will fail due to too many other processes or using
"--stress".

Without run_with_limited_processses() the infinite loop can also be
stopped due to global configrations or quotas, and the verification
still works fine. So let's remove run_with_limited_processses().

Signed-off-by: Han Xin <hanxin.hx@bytedance.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5330-no-lazy-fetch-with-commit-graph.sh

index be3333422993063c794332d0961c298687ff05eb..2cc7fd7a4765b2ba8057591df7588150d453a44a 100755 (executable)
@@ -4,28 +4,6 @@ test_description='test for no lazy fetch with the commit-graph'
 
 . ./test-lib.sh
 
-run_with_limited_processses () {
-       # bash and ksh use "ulimit -u", dash uses "ulimit -p"
-       if test -n "$BASH_VERSION"
-       then
-               ulimit_max_process="-u"
-       elif test -n "$KSH_VERSION"
-       then
-               ulimit_max_process="-u"
-       fi
-       (ulimit ${ulimit_max_process-"-p"} 512 && "$@")
-}
-
-test_lazy_prereq ULIMIT_PROCESSES '
-       run_with_limited_processses true
-'
-
-if ! test_have_prereq ULIMIT_PROCESSES
-then
-       skip_all='skipping tests for no lazy fetch with the commit-graph, ulimit processes not available'
-       test_done
-fi
-
 test_expect_success 'setup: prepare a repository with a commit' '
        git init with-commit &&
        test_commit -C with-commit the-commit &&
@@ -59,8 +37,7 @@ test_expect_success 'fetch any commit from promisor with the usage of the commit
        git -C with-commit-graph config remote.origin.partialclonefilter blob:none &&
        test_commit -C with-commit any-commit &&
        anycommit=$(git -C with-commit rev-parse HEAD) &&
-
-       run_with_limited_processses env GIT_TRACE="$(pwd)/trace.txt" \
+       GIT_TRACE="$(pwd)/trace.txt" \
                git -C with-commit-graph fetch origin $anycommit 2>err &&
        ! grep "fatal: promisor-remote: unable to fork off fetch subprocess" err &&
        grep "git fetch origin" trace.txt >actual &&