]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rxrpc: Don't set the MORE-PACKETS rxrpc wire header flag
authorDavid Howells <dhowells@redhat.com>
Wed, 4 Dec 2024 07:46:33 +0000 (07:46 +0000)
committerJakub Kicinski <kuba@kernel.org>
Mon, 9 Dec 2024 21:48:24 +0000 (13:48 -0800)
The MORE-PACKETS rxrpc header flag hasn't actually been looked at by
anything since 1988 and not all implementations generate it.

Change rxrpc so that it doesn't set MORE-PACKETS at all rather than setting
it inconsistently.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://patch.msgid.link/20241204074710.990092-6-dhowells@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rxrpc/sendmsg.c

index b04afb5df2419b08e7a40d52b6fc87f52651db89..546abb463c3f9e492140457e46c3dc99de59a85f 100644 (file)
@@ -385,9 +385,6 @@ reload:
                    (msg_data_left(msg) == 0 && !more)) {
                        if (msg_data_left(msg) == 0 && !more)
                                txb->flags |= RXRPC_LAST_PACKET;
-                       else if (call->tx_top - call->acks_hard_ack <
-                                call->tx_winsize)
-                               txb->flags |= RXRPC_MORE_PACKETS;
 
                        ret = call->security->secure_packet(call, txb);
                        if (ret < 0)