smbd: Always init symlink_err in filename_convert_dirfsp_nosymlink()

Make sure that we don't leave symlink_err in the caller
uninitialized.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/smbd/filename.c b/source3/smbd/filename.c
index b9bdda3ae0da8abe8d6f073ea861c367b59ecdd8..f37387100ea9e11d511d30cac69db983a0440315 100644 (file)
--- a/source3/smbd/filename.c
+++ b/source3/smbd/filename.c
@@ -808,8 +808,6 @@ filename_convert_dirfsp_nosymlink(TALLOC_CTX *mem_ctx,
                        }
 
                        lnk->unparsed_path_length = unparsed;
-                       *_symlink_err = symlink_err;
-
                        goto fail;
                }
        }
@@ -1054,6 +1052,8 @@ done:
        return NT_STATUS_OK;
 
 fail:
+       *_symlink_err = symlink_err;
+
        /*
         * If open_stream_pathref_fsp() returns an error, smb_fname_rel->fsp
         * has been set to NULL, so we must free base_fsp separately