media: imon: Convert sprintf/snprintf to sysfs_emit

Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
index 5719dda6e0f0ef5ee964872f4fe08fe4e50348b1..0b55314a80827b1aa4d6ea897d4b5220b6fd48ba 100644 (file)
--- a/drivers/media/rc/imon.c
+++ b/drivers/media/rc/imon.c
@@ -845,13 +845,13 @@ static ssize_t imon_clock_show(struct device *d,
        mutex_lock(&ictx->lock);
 
        if (!ictx->display_supported) {
-               len = snprintf(buf, PAGE_SIZE, "Not supported.");
+               len = sysfs_emit(buf, "Not supported.");
        } else {
-               len = snprintf(buf, PAGE_SIZE,
-                       "To set the clock on your iMON display:\n"
-                       "# date \"+%%y %%m %%d %%w %%H %%M %%S\" > imon_clock\n"
-                       "%s", ictx->display_isopen ?
-                       "\nNOTE: imon device must be closed\n" : "");
+               len = sysfs_emit(buf,
+                                "To set the clock on your iMON display:\n"
+                                "# date \"+%%y %%m %%d %%w %%H %%M %%S\" > imon_clock\n"
+                                "%s", ictx->display_isopen ?
+                                "\nNOTE: imon device must be closed\n" : "");
        }
 
        mutex_unlock(&ictx->lock);