]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: mei: csi: Warn less verbosely of a missing device fwnode
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 27 May 2024 20:13:27 +0000 (23:13 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 30 May 2024 14:34:58 +0000 (16:34 +0200)
The check for having device fwnode was meant to be a sanity check but this
also happens if the ACPI DSDT has graph port nodes on sensor device(s) but
not on the IVSC device. Use a more meaningful warning message to tell
about this.

Fixes: 33116eb12c6b ("media: ivsc: csi: Use IPU bridge")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/intel/ivsc/mei_csi.c

index 53151d016188268b911c721a5c511a5a37200d31..f04a89584334bfefdbc321194913978e94310663 100644 (file)
@@ -680,8 +680,10 @@ static int mei_csi_probe(struct mei_cl_device *cldev,
        put_device(&ipu->dev);
        if (ret < 0)
                return ret;
-       if (WARN_ON(!dev_fwnode(dev)))
+       if (!dev_fwnode(dev)) {
+               dev_err(dev, "mei-csi probed without device fwnode!\n");
                return -ENXIO;
+       }
 
        csi = devm_kzalloc(dev, sizeof(struct mei_csi), GFP_KERNEL);
        if (!csi)