dmaengine: xilinx: xilinx_dma: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919133207.1400430-58-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 0a3b2e22f23dbbf339f8ca28b32b6e57942abc78..0c363a1ed853a3744978f48d326bcb340121b1a2 100644 (file)
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -3245,7 +3245,7 @@ disable_clks:
  *
  * Return: Always '0'
  */
-static int xilinx_dma_remove(struct platform_device *pdev)
+static void xilinx_dma_remove(struct platform_device *pdev)
 {
        struct xilinx_dma_device *xdev = platform_get_drvdata(pdev);
        int i;
@@ -3259,8 +3259,6 @@ static int xilinx_dma_remove(struct platform_device *pdev)
                        xilinx_dma_chan_remove(xdev->chan[i]);
 
        xdma_disable_allclks(xdev);
-
-       return 0;
 }
 
 static struct platform_driver xilinx_vdma_driver = {
@@ -3269,7 +3267,7 @@ static struct platform_driver xilinx_vdma_driver = {
                .of_match_table = xilinx_dma_of_ids,
        },
        .probe = xilinx_dma_probe,
-       .remove = xilinx_dma_remove,
+       .remove_new = xilinx_dma_remove,
 };
 
 module_platform_driver(xilinx_vdma_driver);