]> git.ipfire.org Git - thirdparty/tar.git/commitdiff
maint: avoid warnings from upcoming GCC8
authorJim Meyering <meyering@fb.com>
Mon, 19 Mar 2018 00:59:25 +0000 (17:59 -0700)
committerSergey Poznyakoff <gray@gnu.org>
Sat, 7 Apr 2018 07:36:23 +0000 (10:36 +0300)
* src/transform.c (_single_transform_name_to_obstack): Mark with
FALLTHROUGH statement rather than /* FALL THROUGH */ comment.
Only the former works with gcc-8.
* src/extract.c (maybe_recoverable): Call abort to tell gcc-8 that
this code is unreachable.

src/extract.c
src/transform.c

index 395db557328ad34952924a48052fe629935ac46f..74987bbaab4a1f20bb5badadeec8eebf46b71ba7 100644 (file)
@@ -788,6 +788,7 @@ maybe_recoverable (char *file_name, bool regular, bool *interdir_made)
        case UNLINK_FIRST_OLD_FILES:
          break;
        }
+      abort (); /* notreached */
 
     case ENOENT:
       /* Attempt creating missing intermediate directories.  */
index e450dd22ee91f2d1e99c8b4c2d9e00b401cd7af7..3fae3c0d1a1cdd2e7d61ed8ef56c977c09e5192f 100644 (file)
@@ -550,7 +550,7 @@ _single_transform_name_to_obstack (struct transform *tf, char *input)
                        default:
                          break;
                        }
-                     /*FALL THROUGH*/
+                     FALLTHROUGH;
 
                    case ctl_upcase:
                    case ctl_locase: