Fix for bug 128784: Eliminates redundant function call in userprefs.cgi.

Patch by Myk Melez <myk@mozilla.org>
r=gerv x 2

diff --git a/userprefs.cgi b/userprefs.cgi
index 301b90b1e9e3dfc9313f4c1f0f7ded8e32319a41..be8adb3480ecd53dbf3907d0b931de5b32b6d1ca 100755 (executable)
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -38,9 +38,7 @@ sub sillyness {
 }
 
 # Use global template variables.
-use vars qw($template $vars);
-
-my $userid;
+use vars qw($template $vars $userid);
 
 # The default email flags leave all email on.
 my $defaultflagstring = "ExcludeSelf~on~";
@@ -305,8 +303,6 @@ confirm_login();
 
 GetVersionTable();
 
-$userid = DBNameToIdAndCheck($::COOKIE{'Bugzilla_login'});
-
 $vars->{'login'} = $::COOKIE{'Bugzilla_login'};
 $vars->{'changes_saved'} = $::FORM{'dosave'};