[#3213] addressed review comments

diff --git a/ChangeLog b/ChangeLog
index f7ed25a58e18efa6ad2787347dc5828d8b1b0bf7..9d79562ec3ab094bb90cae5c6d609e5f33835f6d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2394.  [func]          razvan
+       Added new 'statistic-global-get-all' command for kea-dhcp4
+       and kea-dhcp6 servers, which returns all statistica except
+       subnet counters.
+       (Gitlab #3213)
+
 2393.  [func]          razvan
        Added global counters for 'assigned-addresses',
        'assigned-nas' and 'assigned-pds'. The 'stat-lease4-get'

diff --git a/doc/sphinx/arm/stats.rst b/doc/sphinx/arm/stats.rst
index 4e85c18889c240dfa95446a42b13543c75feebab..74236c51bdb775e23cad54e714d55a107ba1cfd9 100644 (file)
--- a/doc/sphinx/arm/stats.rst
+++ b/doc/sphinx/arm/stats.rst
@@ -219,10 +219,6 @@ example command may look like this:
        "arguments": { }
    }
 
-The server responds with details of all recorded statistics, with a
-result set to 0 to indicate that it iterated over all statistics (even
-when the total number of statistics is zero).
-
 Here is an example response returning all collected statistics:
 
 ::
@@ -935,7 +931,7 @@ The ``statistic-global-get-all`` Command
 ----------------------------------------
 
 The :isccmd:`statistic-global-get-all` command retrieves all global statistics recorded
-(same as :isccmd:`statistic-global-get-all` but omitting subnet statistics). An example
+(same as :isccmd:`statistic-get-all` but omitting subnet statistics). An example
 command may look like this:
 
 ::
@@ -945,10 +941,6 @@ command may look like this:
        "arguments": { }
    }
 
-The server responds with details of all recorded statistics, with a
-result set to 0 to indicate that it iterated over all statistics (even
-when the total number of statistics is zero).
-
 Here is an example response returning all collected statistics:
 
 ::

diff --git a/src/share/api/statistic-get-all.json b/src/share/api/statistic-get-all.json
index 74a30433b699eb35f29d20ede1a1d25a571f90a7..23f4b58363ffca1ed89fb9c78c7a1fe66c8b0f10 100644 (file)
--- a/src/share/api/statistic-get-all.json
+++ b/src/share/api/statistic-get-all.json
@@ -5,7 +5,7 @@
         "This command retrieves all recorded statistics."
     ],
     "cmd-comment": [
-        "The server responds with the details of all recorded statistics, with a result of 0 indicating that it iterated over all statistics (even when the total number of statistics is zero)."
+        "The server responds with the details of all recorded statistics."
     ],
     "cmd-syntax": [
         "{",

diff --git a/src/share/api/statistic-global-get-all.json b/src/share/api/statistic-global-get-all.json
index e007da52004ddac39c88560c1358dd0ced7d2267..bdcbe09b279d41e25e992686585173305520be2c 100644 (file)
--- a/src/share/api/statistic-global-get-all.json
+++ b/src/share/api/statistic-global-get-all.json
@@ -5,7 +5,7 @@
         "This command retrieves all recorded global statistics (omitting subnet statistics)."
     ],
     "cmd-comment": [
-        "The server responds with the details of all recorded global statistics (omitting subnet statistics), with a result of 0 indicating that it iterated over all global statistics (even when the total number of global statistics is zero)."
+        "The server responds with the details of all recorded global statistics (omitting subnet statistics)."
     ],
     "cmd-syntax": [
         "{",