]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: smp2p: Simplify code with dev_err_probe()
authorZhang Zekun <zhangzekun11@huawei.com>
Mon, 9 Sep 2024 12:29:21 +0000 (20:29 +0800)
committerBjorn Andersson <andersson@kernel.org>
Tue, 29 Oct 2024 20:04:31 +0000 (15:04 -0500)
Use dev_err_probe() directly in the driver probe phase, and we
don't need to judge if the error code is not equal to -EPROBE_DEFER.
This can simplify the code a bit.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Link: https://lore.kernel.org/r/20240909122921.12627-5-zhangzekun11@huawei.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/smp2p.c

index cefcbd61c62815efb1a1bf8a96766b8f57dd5bc4..2731449e220190693531b800c900aa1c594090c3 100644 (file)
@@ -467,12 +467,9 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_smp2p *smp2p)
        int ret;
 
        ret = qcom_smem_alloc(pid, smem_id, sizeof(*out));
-       if (ret < 0 && ret != -EEXIST) {
-               if (ret != -EPROBE_DEFER)
-                       dev_err(smp2p->dev,
-                               "unable to allocate local smp2p item\n");
-               return ret;
-       }
+       if (ret < 0 && ret != -EEXIST)
+               return dev_err_probe(smp2p->dev, ret,
+                                    "unable to allocate local smp2p item\n");
 
        out = qcom_smem_get(pid, smem_id, NULL);
        if (IS_ERR(out)) {