]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kconfig: remove unneeded code in expr_compare_type()
authorMasahiro Yamada <masahiroy@kernel.org>
Tue, 11 Jun 2024 17:55:10 +0000 (02:55 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Mon, 15 Jul 2024 16:08:36 +0000 (01:08 +0900)
The condition (t2 == 0) never becomes true because the zero value
(i.e., E_NONE) is only used as a dummy type for prevtoken. It can
be passed to t1, but not to t2.

The caller of this function only checks expr_compare_type() > 0.
Therefore, the distinction between 0 and -1 is unnecessary.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/expr.c

index fcc190b67b6f6529087eca45d3f8338ac5fba86c..31737b2cb8e27ec792ff0c288cad39cf8ed7c5cc 100644 (file)
@@ -1096,11 +1096,8 @@ static int expr_compare_type(enum expr_type t1, enum expr_type t2)
        case E_OR:
                if (t2 == E_LIST)
                        return 1;
-       case E_LIST:
-               if (t2 == 0)
-                       return 1;
        default:
-               return -1;
+               break;
        }
        return 0;
 }