]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dm/amd/pm: Fix problems with reboot/shutdown for some SMU 13.0.4/13.0.11 users
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 2 May 2024 18:32:17 +0000 (13:32 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 8 May 2024 19:50:47 +0000 (15:50 -0400)
Limit the workaround introduced by commit 31729e8c21ec ("drm/amd/pm: fixes
a random hang in S4 for SMU v13.0.4/11") to only run in the s4 path.

Cc: Tim Huang <Tim.Huang@amd.com>
Fixes: 31729e8c21ec ("drm/amd/pm: fixes a random hang in S4 for SMU v13.0.4/11")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3351
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c

index 949131bd1ecb215c960b7aabb9ad690da715d90c..4abfcd32747d3a6fef57d7089cc9a97ea70290bb 100644 (file)
@@ -226,7 +226,7 @@ static int smu_v13_0_4_system_features_control(struct smu_context *smu, bool en)
        struct amdgpu_device *adev = smu->adev;
        int ret = 0;
 
-       if (!en && !adev->in_s0ix) {
+       if (!en && adev->in_s4) {
                /* Adds a GFX reset as workaround just before sending the
                 * MP1_UNLOAD message to prevent GC/RLC/PMFW from entering
                 * an invalid state.