]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xen: swiotlb: Use swiotlb bouncing if kmalloc allocation demands it
authorJohn Ernberg <john.ernberg@actia.se>
Fri, 2 May 2025 11:40:55 +0000 (11:40 +0000)
committerJuergen Gross <jgross@suse.com>
Wed, 7 May 2025 13:27:42 +0000 (15:27 +0200)
Xen swiotlb support was missed when the patch set starting with
4ab5f8ec7d71 ("mm/slab: decouple ARCH_KMALLOC_MINALIGN from
ARCH_DMA_MINALIGN") was merged.

When running Xen on iMX8QXP, a SoC without IOMMU, the effect was that USB
transfers ended up corrupted when there was more than one URB inflight at
the same time.

Add a call to dma_kmalloc_needs_bounce() to make sure that allocations too
small for DMA get bounced via swiotlb.

Closes: https://lore.kernel.org/linux-usb/ab2776f0-b838-4cf6-a12a-c208eb6aad59@actia.se/
Fixes: 4ab5f8ec7d71 ("mm/slab: decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN")
Cc: stable@kernel.org # v6.5+
Signed-off-by: John Ernberg <john.ernberg@actia.se>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Message-ID: <20250502114043.1968976-2-john.ernberg@actia.se>

drivers/xen/swiotlb-xen.c

index 1f65795cf5d7a2a9b1c83e4c77f9c245ae6e43a5..ef56a2500ed69a70d8628cc3f83f8b969014aeb7 100644 (file)
@@ -217,6 +217,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
         * buffering it.
         */
        if (dma_capable(dev, dev_addr, size, true) &&
+           !dma_kmalloc_needs_bounce(dev, size, dir) &&
            !range_straddles_page_boundary(phys, size) &&
                !xen_arch_need_swiotlb(dev, phys, dev_addr) &&
                !is_swiotlb_force_bounce(dev))