]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
remoteproc: qcom_wcnss: Fix NULL vs IS_ERR() bug in wcnss_alloc_memory_region()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 29 Nov 2025 14:51:10 +0000 (17:51 +0300)
committerBjorn Andersson <andersson@kernel.org>
Sat, 29 Nov 2025 20:18:23 +0000 (14:18 -0600)
The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers.  Update the checking to match.

Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/09a43da41ee277a80a3265348831e747f7b62620.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/remoteproc/qcom_wcnss.c

index 14005fb049a203616076e6cac8e1f8a71ebccf4e..ee18bf2e80549e0ca331778415a06ab8b56fe2ed 100644 (file)
@@ -538,9 +538,9 @@ static int wcnss_alloc_memory_region(struct qcom_wcnss *wcnss)
        wcnss->mem_phys = wcnss->mem_reloc = res.start;
        wcnss->mem_size = resource_size(&res);
        wcnss->mem_region = devm_ioremap_resource_wc(wcnss->dev, &res);
-       if (!wcnss->mem_region) {
+       if (IS_ERR(wcnss->mem_region)) {
                dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res);
-               return -EBUSY;
+               return PTR_ERR(wcnss->mem_region);
        }
 
        return 0;