]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
Move debug log output into separate workflow step.
authorDarren Tucker <dtucker@dtucker.net>
Sun, 11 May 2025 06:35:31 +0000 (16:35 +1000)
committerDarren Tucker <dtucker@dtucker.net>
Wed, 21 May 2025 05:04:01 +0000 (15:04 +1000)
Should reduce the need to scroll back to find out which test actually
failed.

.github/run_test.sh
.github/workflows/c-cpp.yml
.github/workflows/selfhosted.yml

index 74ab2423c0d8b50c104827542fac7332e4ba2d8e..bd6fb7b7b3e1087b6cc19ad517117d092b028215 100755 (executable)
@@ -21,18 +21,6 @@ if [ ! -z "$SUDO" ] && [ ! -z "$TEST_SSH_HOSTBASED_AUTH" ]; then
     done
 fi
 
-output_failed_logs() {
-    for i in regress/failed*.log; do
-        if [ -f "$i" ]; then
-            echo -------------------------------------------------------------------------
-            echo LOGFILE $i
-            cat $i
-            echo -------------------------------------------------------------------------
-        fi
-    done
-}
-trap output_failed_logs 0
-
 env=""
 if [ ! -z "${SUDO}" ]; then
     env="${env} SUDO=${SUDO}"
index 903ed64b555209ed916b99870c6affbc096acae7..cb6c69dad21c483ceff903376849255d38828bbc 100644 (file)
@@ -143,6 +143,9 @@ jobs:
       env:
         TEST_SSH_UNSAFE_PERMISSIONS: 1
         TEST_SSH_HOSTBASED_AUTH: yes
+    - name: show logs
+      if: failure()
+      run: for i in regress/failed*.log; do echo ====; echo logfile $i; echo =====; cat $i; done
     - name: save logs
       if: failure()
       uses: actions/upload-artifact@main
index d892a28c3eb6efa142a816c18bf0c3eddc9abda8..9f2bd99eb1316d06bf6158c5dab05ac96ede08fb 100644 (file)
@@ -129,6 +129,9 @@ jobs:
     - name: make tests
       run: vmrun ./.github/run_test.sh ${{ matrix.config }}
       timeout-minutes: 600
+    - name: show logs
+      if: failure()
+      run: vmrun 'for i in regress/failed*.log; do echo ====; echo logfile $i; echo =====; cat $i; done'
     - name: save logs
       if: failure()
       uses: actions/upload-artifact@main