Remove a superfluous call to access() in the unix driver. Error spotted

by Coverity. (CVS 3175)

FossilOrigin-Name: 4f195aa1ebef5129e6f912e78b3d5f97b393a06c

diff --git a/manifest b/manifest
index 46033297e6fe4ec20207c4a4fa0427bcb0445c59..43658c400aae039aece8066223b3e941ced9bbae 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Allocate\senough\smemory\sfor\sthe\sworst-case\sUTF-16\sto\sUTF-8\sconversion.\nTicket\s#1773.\s(CVS\s3174)
-D 2006-04-16T12:05:03
+C Remove\sa\ssuperfluous\scall\sto\saccess()\sin\sthe\sunix\sdriver.\s\sError\sspotted\nby\sCoverity.\s(CVS\s3175)
+D 2006-04-19T01:24:53
 F Makefile.in 5d8dff443383918b700e495de42ec65bc1c8865b
 F Makefile.linux-gcc 74ba0eadf88748a9ce3fd03d2a3ede2e6715baec
 F README 9c4e2d6706bdcc3efdd773ce752a8cdab4f90028
@@ -55,7 +55,7 @@ F src/os.h 93035a0e3b9dd05cdd0aaef32ea28ca28e02fe78
 F src/os_common.h 108cd719c96a2b714b64e02aeabbd40684274e6a
 F src/os_test.c 49833426101f99aee4bb5f6a44b7c4b2029fda1c
 F src/os_test.h 903c93554c23d88f34f667f1979e4a1cee792af3
-F src/os_unix.c 35ad4d81c90800f509d28580742b67906d289223
+F src/os_unix.c 17d91581a0ab478a06cb6f257b707a4c4a93e5a7
 F src/os_unix.h 5768d56d28240d3fe4537fac08cc85e4fb52279e
 F src/os_win.c 8ced9ac82670bbf77492961a2f7ff80a87f1404f
 F src/os_win.h 41a946bea10f61c158ce8645e7646b29d44f122b
@@ -355,7 +355,7 @@ F www/tclsqlite.tcl bb0d1357328a42b1993d78573e587c6dcbc964b9
 F www/vdbe.tcl 87a31ace769f20d3627a64fa1fade7fed47b90d0
 F www/version3.tcl 890248cf7b70e60c383b0e84d77d5132b3ead42b
 F www/whentouse.tcl 97e2b5cd296f7d8057e11f44427dea8a4c2db513
-P d83e0230c0c4909cb035e266beffc0967526d9c1
-R 1e1e9e36a8b198dfc78ebe03fb97ac0f
+P 2a0120c0f06d17185ede773729d97c93f90923ff
+R bbc3e7076a63308418057690860dfefb
 U drh
-Z fad61796400585d36aa31de63a9d3216
+Z 3cf4dbb6bb7d078e42f81cc335b564c2

diff --git a/manifest.uuid b/manifest.uuid
index 3da0ea228835acfeb2b0088339c51ab2d1c4e1d9..8563711ba69d8ae560b57ec1a8fbc441977978a1 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-2a0120c0f06d17185ede773729d97c93f90923ff
\ No newline at end of file
+4f195aa1ebef5129e6f912e78b3d5f97b393a06c
\ No newline at end of file

diff --git a/src/os_unix.c b/src/os_unix.c
index 6dcc43ebe993000f5608c38181d1dcabde43e8fa..5b58cb7aac273230773082c477b399fa5f5af18a 100644 (file)
--- a/src/os_unix.c
+++ b/src/os_unix.c
@@ -752,9 +752,6 @@ int sqlite3UnixOpenExclusive(const char *zFilename, OsFile **pId, int delFlag){
 
   CRASH_TEST_OVERRIDE(sqlite3CrashOpenExclusive, zFilename, pId, delFlag);
   assert( 0==*pId );
-  if( access(zFilename, 0)==0 ){
-    return SQLITE_CANTOPEN;
-  }
   f.h = open(zFilename,
                 O_RDWR|O_CREAT|O_EXCL|O_NOFOLLOW|O_LARGEFILE|O_BINARY,
                 SQLITE_DEFAULT_FILE_PERMISSIONS);