options.c: fix format security error when compiling without optimization

error: format not a string literal and no format arguments
[-Werror=format-security]
 2309 |     msg(M_USAGE, str);

Found by accident, since it only happens without optimization.
Seems the compiler can figure out that this is harmless when
thinking a bit harder about it. Fix anyway.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20221228110752.34060-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25848.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 24fc4ce25432a42170477f21133bb0f25a8a860d)

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index e454b2ac024316093a4f86e682917072002760ef..7395019e31657f9f29f99d09298d0f550af6f232 100644 (file)
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -2306,7 +2306,7 @@ check_ca_required(const struct options *options)
                             " or CA path (--capath)"
 #endif
                             " and/or peer fingerprint verification (--peer-fingerprint)";
-    msg(M_USAGE, str);
+    msg(M_USAGE, "%s", str);
 }
 
 static void