Enable mod_cgid stderr handling via Unix socket fd transfer by

default, rather than as an opt-in configure flag.  (This has been
tested in Fedora for >12 months without seeing any new problems)

* configure.in: Check for CMSG_DATA here, and define HAVE_FDPASSING
  and $ap_has_fdpassing if fd passing is supported.

* modules/generator/config5.m4,
  modules/generator/mod_cgid.c: Drop configure flag for mod_cgid
  fdpassing support, instead enable where possible by default.

* modules/proxy/config.m4: Rely on configure test for CMSG_DATA.

* .travis.yml: Switch test for cgid fdpassing for testing w/o
  CMSG_DATA.

Github: closes #172
PR: 54221

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1886912 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/.travis.yml b/.travis.yml
index 99f1d0c61227344cd008444c9b6bf09b4bd8d12b..455e1d861849aa4fddbd9885780c6897bc47a265 100644 (file)
--- a/.travis.yml
+++ b/.travis.yml
@@ -117,9 +117,8 @@ jobs:
     - name: Linux Ubuntu, Event MPM, all-modules, mod_cgid only
       env: CONFIG="--enable-mods-shared=reallyall --with-mpm=event --disable-cgi"
     # -------------------------------------------------------------------------
-    - if: *condition_not_24x
-      name: Linux Ubuntu, Event MPM, all-modules, mod_cgid fdpassing
-      env: CONFIG="--enable-mods-shared=reallyall --with-mpm=event --disable-cgi --enable-cgid-fdpassing"
+    - name: Linux Ubuntu, Event MPM, all-modules, no CMSG_DATA
+      env: CONFIG="--enable-mods-shared=reallyall --with-mpm=event ac_cv_have_decl_CMSG_DATA=no"
     # -------------------------------------------------------------------------
     - if: *condition_not_24x
       name: Linux Ubuntu, PCRE 1, GCC 7 maintainer-mode w/-Werror

diff --git a/CHANGES b/CHANGES
index fdba2ab645441c0baf0ac5f852048a40f84c5dd3..675e0f3bbb83fff6159694ccd1c18653f1bb1153 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.1
 
+  *) mod_cgid: Intercept and log stderr output correctly on Unix systems
+     supporting fd passing.  PR 54221.  [Joe Orton]
+
   *) mod_auth_digest: Fast validation of the nonce's base64 to fail early if
      the format can't match anyway.  [Yann Ylavic]
 

diff --git a/configure.in b/configure.in
index 0e81ab5510f7401c3bc95126fb3e8016fd48c9f8..9a56af7c76e4f321a517fab39019e6339993607f 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -567,6 +567,16 @@ if test "$ac_cv_struct_tm_gmtoff" = "yes"; then
     AC_DEFINE(HAVE_GMTOFF, 1, [Define if struct tm has a tm_gmtoff field])
 fi
 
+AC_CHECK_DECL(CMSG_DATA,,, [#include <sys/types.h>
+#include <sys/socket.h>])
+if test $ac_cv_have_decl_CMSG_DATA = "yes"; then
+   AC_DEFINE([HAVE_FDPASSING], 1, [Define if file descriptor passing is supported])
+   ap_has_fdpassing=1
+else
+   ap_has_fdpassing=0
+   AC_MSG_WARN([This system does not support file descriptor passing.])
+fi
+
 APACHE_CHECK_SYSTEMD
 
 dnl ## Set up any appropriate OS-specific environment variables for apachectl

diff --git a/modules/generators/config5.m4 b/modules/generators/config5.m4
index 3ffd19a5c3e82c55fd7e72a7dfa2f64a86a30cd0..da3314093899e10a8b603b62017ba15f6bebbedd 100644 (file)
--- a/modules/generators/config5.m4
+++ b/modules/generators/config5.m4
@@ -78,15 +78,4 @@ fi
 
 APR_ADDTO(INCLUDES, [-I\$(top_srcdir)/$modpath_current])
 
-AC_ARG_ENABLE(cgid-fdpassing,
-  [APACHE_HELP_STRING(--enable-cgid-fdpassing,Enable experimental mod_cgid support for fd passing)],
-  [if test "$enableval" = "yes"; then
-     AC_CHECK_DECL(CMSG_DATA,
-       [AC_DEFINE([HAVE_CGID_FDPASSING], 1, [Enable FD passing support in mod_cgid])],
-       [AC_MSG_ERROR([cannot support mod_cgid fd-passing on this system])], [
-#include <sys/types.h>
-#include <sys/socket.h>])
-  fi
-])
-
 APACHE_MODPATH_FINISH

diff --git a/modules/generators/mod_cgid.c b/modules/generators/mod_cgid.c
index b821b69b9aff1224019ad44f677476a297a03a1c..1636ad41f1449abd4679c374b9e64272381175cd 100644 (file)
--- a/modules/generators/mod_cgid.c
+++ b/modules/generators/mod_cgid.c
@@ -218,7 +218,7 @@ typedef struct {
 #define cgi_server_conf cgid_server_conf
 #define cgi_module cgid_module
 
-#ifdef HAVE_CGID_FDPASSING
+#ifdef HAVE_FDPASSING
 /* Pull in CGI bucket implementation. */
 #define WANT_CGI_BUCKET
 #endif
@@ -353,7 +353,7 @@ static apr_status_t close_unix_socket(void *thefd)
 static apr_status_t sock_readhdr(int fd, int *errfd, void *vbuf, size_t buf_size)
 {
     int rc;
-#ifndef HAVE_CGID_FDPASSING
+#ifndef HAVE_FDPASSING
     char *buf = vbuf;
     size_t bytes_read = 0;
 
@@ -458,7 +458,7 @@ static apr_status_t sock_writev(int fd, int auxfd, request_rec *r, int count, ..
     }
     va_end(ap);
 
-#ifndef HAVE_CGID_FDPASSING
+#ifndef HAVE_FDPASSING
     do {
         rc = writev(fd, vec, count);
     } while (rc < 0 && errno == EINTR);
@@ -1541,7 +1541,7 @@ static int cgid_handler(request_rec *r)
     }
     */
 
-#ifdef HAVE_CGID_FDPASSING
+#ifdef HAVE_FDPASSING
     rv = apr_file_pipe_create(&script_err, &errpipe_out, r->pool);
     if (rv) {
         return log_scripterror(r, conf, HTTP_SERVICE_UNAVAILABLE, rv, APLOGNO(10176),
@@ -1623,7 +1623,7 @@ static int cgid_handler(request_rec *r)
     shutdown(sd, 1);
 
     bb = apr_brigade_create(r->pool, c->bucket_alloc);
-#ifdef HAVE_CGID_FDPASSING
+#ifdef HAVE_FDPASSING
     b = cgi_bucket_create(r, dc->timeout, tempsock, script_err, c->bucket_alloc);
     if (b == NULL)
         return HTTP_INTERNAL_SERVER_ERROR; /* should call log_scripterror() w/ _UNAVAILABLE? */

diff --git a/modules/proxy/config.m4 b/modules/proxy/config.m4
index d9bfd7a1cec07c43e56efb8702ddcd40a51db6a5..34346a669855b6a8b6996314e4488a2b7b886ace 100644 (file)
--- a/modules/proxy/config.m4
+++ b/modules/proxy/config.m4
@@ -40,12 +40,7 @@ APACHE_MODULE(proxy_fcgi, Apache proxy FastCGI module.  Requires --enable-proxy.
 APACHE_MODULE(proxy_scgi, Apache proxy SCGI module.  Requires --enable-proxy., $proxy_scgi_objs, , most, , proxy)
 APACHE_MODULE(proxy_uwsgi, Apache proxy UWSGI module.  Requires --enable-proxy., $proxy_uwsgi_objs, , most, , proxy)
 APACHE_MODULE(proxy_fdpass, Apache proxy to Unix Daemon Socket module.  Requires --enable-proxy., $proxy_fdpass_objs, , most, [
-  AC_CHECK_DECL(CMSG_DATA,,, [
-    #include <sys/types.h>
-    #include <sys/socket.h>
-  ])
-  if test $ac_cv_have_decl_CMSG_DATA = "no"; then
-    AC_MSG_WARN([Your system does not support CMSG_DATA.])
+  if test $ap_has_fdpassing = 0; then
     enable_proxy_fdpass=no
   fi
 ],proxy)