]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: qla2xxx: Return ENOBUFS if sg_cnt is more than one for ELS cmds
authorSaurav Kashyap <skashyap@marvell.com>
Wed, 10 Jul 2024 17:10:50 +0000 (22:40 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 11 Jul 2024 02:44:10 +0000 (22:44 -0400)
Firmware only supports single DSDs in ELS Pass-through IOCB (0x53h), sg cnt
is decided by the SCSI ML. User is not aware of the cause of an acutal
error.

Return the appropriate return code that will be decoded by API and
application and proper error message will be displayed to user.

Fixes: 6e98016ca077 ("[SCSI] qla2xxx: Re-organized BSG interface specific code.")
Cc: stable@vger.kernel.org
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-5-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_bsg.c

index 19bb64bdd88b1931f92df08456001b17efb270f7..8d1e45b883cd1d51ae25b9f2da0c51bf3a1dfc0c 100644 (file)
@@ -324,7 +324,7 @@ qla2x00_process_els(struct bsg_job *bsg_job)
                    "request_sg_cnt=%x reply_sg_cnt=%x.\n",
                    bsg_job->request_payload.sg_cnt,
                    bsg_job->reply_payload.sg_cnt);
-               rval = -EPERM;
+               rval = -ENOBUFS;
                goto done;
        }