]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
mkfs.xfs: annotate fallthrough cases in cvtnum
authorEric Sandeen <sandeen@sandeen.net>
Mon, 30 May 2016 02:21:31 +0000 (12:21 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 30 May 2016 02:21:31 +0000 (12:21 +1000)
We should really collapse our 3 cvtnum variants,
but for now at least shut up Coverity about this
intentional case fallthrough.

Addresses-Coverity-ID: 1361553
Addresses-Coverity-ID: 1361554
Addresses-Coverity-ID: 1361555
Addresses-Coverity-ID: 1361556
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
mkfs/xfs_mkfs.c

index ad3fd775685b93983ab1c76f4dbbba402fba993a..1593ee893f922f719219fd820137b526848630dc 100644 (file)
@@ -3298,14 +3298,19 @@ cvtnum(
        switch (c) {
        case 'e':
                i *= 1024LL;
+               /* fall through */
        case 'p':
                i *= 1024LL;
+               /* fall through */
        case 't':
                i *= 1024LL;
+               /* fall through */
        case 'g':
                i *= 1024LL;
+               /* fall through */
        case 'm':
                i *= 1024LL;
+               /* fall through */
        case 'k':
                return i * 1024LL;
        default: