fbnic: Do not allow mailbox to toggle to ready outside fbnic_mbx_poll_tx_ready

We had originally thought to have the mailbox go to ready in the background
while we were doing other things. One issue with this though is that we
can't disable it by clearing the ready state without also blocking
interrupts or calls to mbx_poll as it will just pop back to life during an
interrupt.

In order to prevent that from happening we can pull the code for toggling
to ready out of the interrupt path and instead place it in the
fbnic_mbx_poll_tx_ready path so that it becomes the only spot where the
Rx/Tx can toggle to the ready state. By doing this we can prevent races
where we disable the DMA and/or free buffers only to have an interrupt fire
and undo what we have done.

Fixes: da3cde08209e ("eth: fbnic: Add FW communication mechanism")
Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/174654722518.499179.11612865740376848478.stgit@ahduyck-xeon-server.home.arpa
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
index 90a45c7015436fa39fa882d9880d20cb7f39c3ea..3d9636a6c968ecfbdb12dd7cc4690e5c4ea170cb 100644 (file)
--- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
@@ -356,10 +356,6 @@ static void fbnic_mbx_init_desc_ring(struct fbnic_dev *fbd, int mbx_idx)
 {
        struct fbnic_fw_mbx *mbx = &fbd->mbx[mbx_idx];
 
-       /* This is a one time init, so just exit if it is completed */
-       if (mbx->ready)
-               return;
-
        mbx->ready = true;
 
        switch (mbx_idx) {
@@ -379,21 +375,18 @@ static void fbnic_mbx_init_desc_ring(struct fbnic_dev *fbd, int mbx_idx)
        }
 }
 
-static void fbnic_mbx_postinit(struct fbnic_dev *fbd)
+static bool fbnic_mbx_event(struct fbnic_dev *fbd)
 {
-       int i;
-
        /* We only need to do this on the first interrupt following reset.
         * this primes the mailbox so that we will have cleared all the
         * skip descriptors.
         */
        if (!(rd32(fbd, FBNIC_INTR_STATUS(0)) & (1u << FBNIC_FW_MSIX_ENTRY)))
-               return;
+               return false;
 
        wr32(fbd, FBNIC_INTR_CLEAR(0), 1u << FBNIC_FW_MSIX_ENTRY);
 
-       for (i = 0; i < FBNIC_IPC_MBX_INDICES; i++)
-               fbnic_mbx_init_desc_ring(fbd, i);
+       return true;
 }
 
 /**
@@ -870,7 +863,7 @@ next_page:
 
 void fbnic_mbx_poll(struct fbnic_dev *fbd)
 {
-       fbnic_mbx_postinit(fbd);
+       fbnic_mbx_event(fbd);
 
        fbnic_mbx_process_tx_msgs(fbd);
        fbnic_mbx_process_rx_msgs(fbd);
@@ -879,11 +872,9 @@ void fbnic_mbx_poll(struct fbnic_dev *fbd)
 int fbnic_mbx_poll_tx_ready(struct fbnic_dev *fbd)
 {
        unsigned long timeout = jiffies + 10 * HZ + 1;
-       struct fbnic_fw_mbx *tx_mbx;
-       int err;
+       int err, i;
 
-       tx_mbx = &fbd->mbx[FBNIC_IPC_MBX_TX_IDX];
-       while (!tx_mbx->ready) {
+       do {
                if (!time_is_after_jiffies(timeout))
                        return -ETIMEDOUT;
 
@@ -898,9 +889,11 @@ int fbnic_mbx_poll_tx_ready(struct fbnic_dev *fbd)
                        return -ENODEV;
 
                msleep(20);
+       } while (!fbnic_mbx_event(fbd));
 
-               fbnic_mbx_poll(fbd);
-       }
+       /* FW has shown signs of life. Enable DMA and start Tx/Rx */
+       for (i = 0; i < FBNIC_IPC_MBX_INDICES; i++)
+               fbnic_mbx_init_desc_ring(fbd, i);
 
        /* Request an update from the firmware. This should overwrite
         * mgmt.version once we get the actual version from the firmware