]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regmap: mdio: Fix regmap_bus pointer constness
authorSander Vanheule <sander@svanheule.net>
Wed, 9 Jun 2021 13:10:03 +0000 (15:10 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 14 Jun 2021 14:00:28 +0000 (15:00 +0100)
A const qualifier was omitted in the declaration of the regmap_bus
pointer, resulting in the following errors:

drivers/base/regmap/regmap-mdio.c: In function ‘__regmap_init_mdio’:
drivers/base/regmap/regmap-mdio.c:87:7: warning: assignment discards
‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   87 |   bus = &regmap_mdio_c22_bus;
      |       ^
drivers/base/regmap/regmap-mdio.c:89:7: warning: assignment discards
‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   89 |   bus = &regmap_mdio_c45_bus;
      |       ^

Fix this by ensuring the pointer has the same qualifiers as the assigned
values.

Fixes: f083be9db060 ("regmap: mdio: Add clause-45 support")
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Link: https://lore.kernel.org/r/f304ca638ffdc66d4803a6df1f75436894bd1d5f.1623244066.git.sander@svanheule.net
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap-mdio.c

index cfb23afb19ebf47213d0b9039ad7ba7a6df878b6..b772b42809e2895ff205c386aeb49eddabf5ecc9 100644 (file)
@@ -69,7 +69,7 @@ struct regmap *__regmap_init_mdio(struct mdio_device *mdio_dev,
        const struct regmap_config *config, struct lock_class_key *lock_key,
        const char *lock_name)
 {
-       struct regmap_bus *bus;
+       const struct regmap_bus *bus;
 
        if (config->reg_bits == 5 && config->val_bits == 16)
                bus = &regmap_mdio_c22_bus;