]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Avoid double assignment in virDomainDiskRemove
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 13 Apr 2012 09:19:29 +0000 (11:19 +0200)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 16 Apr 2012 11:43:38 +0000 (12:43 +0100)
Although it should be harmless to do:
    disk = disk = def->disks[i]
some not-so-wise compilers may fool around.
Besides, such assignment is useless here.
(cherry picked from commit e14d6571c1185133d15161bb4b18ec9b11192358)

src/conf/domain_conf.c

index c6b97e1e5241433e06700337bf8fcf25edb469ac..a9c5cbce21ac01df51ad45c69c97f94dd198e564 100644 (file)
@@ -7124,7 +7124,7 @@ void virDomainDiskInsertPreAlloced(virDomainDefPtr def,
 virDomainDiskDefPtr
 virDomainDiskRemove(virDomainDefPtr def, size_t i)
 {
-    virDomainDiskDefPtr disk = disk = def->disks[i];
+    virDomainDiskDefPtr disk = def->disks[i];
 
     if (def->ndisks > 1) {
         memmove(def->disks + i,