]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:kdc: Switch to using smb_krb5_princ_component()
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 5 Sep 2023 04:46:08 +0000 (16:46 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 14 Sep 2023 21:35:29 +0000 (21:35 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/kdc/db-glue.c

index ea90f9e21852618fe7e9d26c62a79a58232460a1..d421e6ead614744f8021805a9b82e5f92f9dddec 100644 (file)
@@ -888,17 +888,18 @@ static int principal_comp_strcmp_int(krb5_context context,
        }
 #else
        size_t len;
-       krb5_data *d;
+       krb5_data d;
+       krb5_error_code ret = 0;
        if (component >= krb5_princ_size(context, principal)) {
                return -1;
        }
 
-       d = krb5_princ_component(context, principal, component);
-       if (d == NULL) {
+       ret = smb_krb5_princ_component(context, principal, component, &d);
+       if (ret) {
                return -1;
        }
 
-       p = d->data;
+       p = d.data;
 
        len = strlen(string);
 
@@ -907,9 +908,9 @@ static int principal_comp_strcmp_int(krb5_context context,
         * give the wrong result if the result overflows or loses data when
         * narrowed to int.
         */
-       if (d->length < len) {
+       if (d.length < len) {
                return -1;
-       } else if (d->length > len) {
+       } else if (d.length > len) {
                return 1;
        }