]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
bcachefs: Logged op errors should be ignored
authorKent Overstreet <kent.overstreet@linux.dev>
Mon, 1 Apr 2024 02:34:45 +0000 (22:34 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Mon, 1 Apr 2024 04:04:10 +0000 (00:04 -0400)
If something is wrong with a logged op, we just want to delete it -
there's nothing to repair.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/logged_ops.c

index 9fac838d123e8e40fb836d895afccde634f2d54c..b82f8209041ffb47506d7971382d614cdda9005b 100644 (file)
@@ -37,7 +37,6 @@ static int resume_logged_op(struct btree_trans *trans, struct btree_iter *iter,
        const struct bch_logged_op_fn *fn = logged_op_fn(k.k->type);
        struct bkey_buf sk;
        u32 restart_count = trans->restart_count;
-       int ret;
 
        if (!fn)
                return 0;
@@ -45,11 +44,11 @@ static int resume_logged_op(struct btree_trans *trans, struct btree_iter *iter,
        bch2_bkey_buf_init(&sk);
        bch2_bkey_buf_reassemble(&sk, c, k);
 
-       ret =   drop_locks_do(trans, (bch2_fs_lazy_rw(c), 0)) ?:
-               fn->resume(trans, sk.k) ?: trans_was_restarted(trans, restart_count);
+       fn->resume(trans, sk.k);
 
        bch2_bkey_buf_exit(&sk, c);
-       return ret;
+
+       return trans_was_restarted(trans, restart_count);
 }
 
 int bch2_resume_logged_ops(struct bch_fs *c)