]> git.ipfire.org Git - people/ms/gcc.git/commitdiff
c++: suppress -Wdangling-reference for std::span [PR107532]
authorMarek Polacek <polacek@redhat.com>
Fri, 10 Mar 2023 17:23:13 +0000 (12:23 -0500)
committerMarek Polacek <polacek@redhat.com>
Mon, 13 Mar 2023 15:21:25 +0000 (11:21 -0400)
std::span is a view and therefore should be treated as a reference
wrapper class for the purposes of -Wdangling-reference.  I'm not sure
there's a pattern that we could check for.

PR c++/107532

gcc/cp/ChangeLog:

* call.cc (reference_like_class_p): Check for std::span.

gcc/testsuite/ChangeLog:

* g++.dg/warn/Wdangling-reference10.C: New test.

gcc/cp/call.cc
gcc/testsuite/g++.dg/warn/Wdangling-reference10.C [new file with mode: 0644]

index 3dfa12a07336739bf728fa8717f29f9b29b2f7e6..c01e7b82457fedd93d55e0bd373260f61c464047 100644 (file)
@@ -13800,6 +13800,7 @@ reference_like_class_p (tree ctype)
       tree name = DECL_NAME (tdecl);
       return (name
              && (id_equal (name, "reference_wrapper")
+                 || id_equal (name, "span")
                  || id_equal (name, "ref_view")));
     }
   for (tree fields = TYPE_FIELDS (ctype);
diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-reference10.C b/gcc/testsuite/g++.dg/warn/Wdangling-reference10.C
new file mode 100644 (file)
index 0000000..733fb8c
--- /dev/null
@@ -0,0 +1,12 @@
+// PR c++/107532
+// { dg-do compile { target c++20 } }
+// { dg-options "-Wdangling-reference" }
+
+#include <span>
+#include <vector>
+
+void f(const std::vector<int>& v)
+{
+  const int& r = std::span<const int>(v)[0]; // { dg-bogus "dangling reference" }
+  (void) r;
+}