tty: pcn_uart: fix memory leak with using debugfs_lookup()

[ Upstream commit 04a189c720aa2b6091442113ce9b9bc93552dff8 ]

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230202141221.2293012-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 49bc5a4b2832786801062e94f9fff947582ee2ec..e783a4225bf04af295f8c215efa541f1e2235c2b 100644 (file)
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -1821,7 +1821,7 @@ static void pch_uart_exit_port(struct eg20t_port *priv)
        char name[32];
 
        snprintf(name, sizeof(name), "uart%d_regs", priv->port.line);
-       debugfs_remove(debugfs_lookup(name, NULL));
+       debugfs_lookup_and_remove(name, NULL);
        uart_remove_one_port(&pch_uart_driver, &priv->port);
        free_page((unsigned long)priv->rxbuf.buf);
 }