]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.14-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Sep 2020 12:27:50 +0000 (14:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Sep 2020 12:27:50 +0000 (14:27 +0200)
added patches:
serial-8250_pci-add-realtek-816a-and-816b.patch
thunderbolt-retry-drom-read-once-if-parsing-fails.patch

queue-4.14/serial-8250_pci-add-realtek-816a-and-816b.patch [new file with mode: 0644]
queue-4.14/series
queue-4.14/thunderbolt-retry-drom-read-once-if-parsing-fails.patch [new file with mode: 0644]

diff --git a/queue-4.14/serial-8250_pci-add-realtek-816a-and-816b.patch b/queue-4.14/serial-8250_pci-add-realtek-816a-and-816b.patch
new file mode 100644 (file)
index 0000000..052c14b
--- /dev/null
@@ -0,0 +1,118 @@
+From 3c5a87be170aba8ac40982182f812dcff6ed1ad1 Mon Sep 17 00:00:00 2001
+From: Tobias Diedrich <tobiasdiedrich@gmail.com>
+Date: Mon, 14 Sep 2020 19:36:28 +0200
+Subject: serial: 8250_pci: Add Realtek 816a and 816b
+
+From: Tobias Diedrich <tobiasdiedrich@gmail.com>
+
+commit 3c5a87be170aba8ac40982182f812dcff6ed1ad1 upstream.
+
+These serial ports are exposed by the OOB-management-engine on
+RealManage-enabled network cards (e.g. AMD DASH enabled systems using
+Realtek cards).
+
+Because these have 3 BARs, they fail the "num_iomem <= 1" check in
+serial_pci_guess_board.
+
+I've manually checked the two IOMEM regions and BAR 2 doesn't seem to
+respond to reads, but BAR 4 seems to be an MMIO version of the IO ports
+(untested).
+
+With this change, the ports are detected:
+0000:02:00.1: ttyS0 at I/O 0x2200 (irq = 82, base_baud = 115200) is a 16550A
+0000:02:00.2: ttyS1 at I/O 0x2100 (irq = 55, base_baud = 115200) is a 16550A
+
+lspci output:
+02:00.1 0700: 10ec:816a (rev 0e) (prog-if 02 [16550])
+        Subsystem: 17aa:5082
+        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
+        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort+ <TAbort- <MAbort- >SERR- <PERR- INTx-
+        Interrupt: pin B routed to IRQ 82
+        IOMMU group: 11
+        Region 0: I/O ports at 2200 [size=256]
+        Region 2: Memory at fd715000 (64-bit, non-prefetchable) [size=4K]
+        Region 4: Memory at fd704000 (64-bit, non-prefetchable) [size=16K]
+        Capabilities: [40] Power Management version 3
+                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
+                Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
+        Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
+                Address: 0000000000000000  Data: 0000
+        Capabilities: [70] Express (v2) Endpoint, MSI 01
+                DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s unlimited, L1 <64us
+                        ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- SlotPowerLimit 0.000W
+                DevCtl: CorrErr- NonFatalErr- FatalErr- UnsupReq-
+                        RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
+                        MaxPayload 128 bytes, MaxReadReq 512 bytes
+                DevSta: CorrErr+ NonFatalErr- FatalErr- UnsupReq+ AuxPwr+ TransPend-
+                LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s unlimited, L1 <64us
+                        ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp+
+                LnkCtl: ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
+                        ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
+                LnkSta: Speed 2.5GT/s (ok), Width x1 (ok)
+                        TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
+                DevCap2: Completion Timeout: Range ABCD, TimeoutDis+ NROPrPrP- LTR+
+                         10BitTagComp- 10BitTagReq- OBFF Via message/WAKE#, ExtFmt- EETLPPrefix-
+                         EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit-
+                         FRS- TPHComp- ExtTPHComp-
+                         AtomicOpsCap: 32bit- 64bit- 128bitCAS-
+                DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF Disabled,
+                         AtomicOpsCtl: ReqEn-
+                LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete- EqualizationPhase1-
+                         EqualizationPhase2- EqualizationPhase3- LinkEqualizationRequest-
+                         Retimer- 2Retimers- CrosslinkRes: unsupported
+        Capabilities: [b0] MSI-X: Enable- Count=4 Masked-
+                Vector table: BAR=4 offset=00000000
+                PBA: BAR=4 offset=00000800
+        Capabilities: [d0] Vital Product Data
+                Not readable
+        Capabilities: [100 v2] Advanced Error Reporting
+                UESta:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
+                UEMsk:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
+                UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
+                CESta:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
+                CEMsk:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
+                AERCap: First Error Pointer: 00, ECRCGenCap+ ECRCGenEn- ECRCChkCap+ ECRCChkEn-
+                        MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
+                HeaderLog: 00000000 00000000 00000000 00000000
+        Capabilities: [160 v1] Device Serial Number 00-00-00-00-00-00-00-00
+        Capabilities: [170 v1] Latency Tolerance Reporting
+                Max snoop latency: 0ns
+                Max no snoop latency: 0ns
+        Capabilities: [178 v1] L1 PM Substates
+                L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+ L1_PM_Substates+
+                          PortCommonModeRestoreTime=150us PortTPowerOnTime=150us
+                L1SubCtl1: PCI-PM_L1.2- PCI-PM_L1.1- ASPM_L1.2- ASPM_L1.1-
+                           T_CommonMode=0us LTR1.2_Threshold=0ns
+                L1SubCtl2: T_PwrOn=10us
+02:00.2 0700: 10ec:816b (rev 0e)
+[...same...]
+
+Signed-off-by: Tobias Diedrich <tobiasdiedrich@gmail.com>
+Cc: stable <stable@vger.kernel.org>
+Link: https://lore.kernel.org/r/20200914173628.GA22508@yamamaya.is-a-geek.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/tty/serial/8250/8250_pci.c |   11 +++++++++++
+ 1 file changed, 11 insertions(+)
+
+--- a/drivers/tty/serial/8250/8250_pci.c
++++ b/drivers/tty/serial/8250/8250_pci.c
+@@ -5247,6 +5247,17 @@ static const struct pci_device_id serial
+               PCI_ANY_ID, PCI_ANY_ID,
+               0, 0, pbn_wch384_4 },
++      /*
++       * Realtek RealManage
++       */
++      {       PCI_VENDOR_ID_REALTEK, 0x816a,
++              PCI_ANY_ID, PCI_ANY_ID,
++              0, 0, pbn_b0_1_115200 },
++
++      {       PCI_VENDOR_ID_REALTEK, 0x816b,
++              PCI_ANY_ID, PCI_ANY_ID,
++              0, 0, pbn_b0_1_115200 },
++
+       /* Fintek PCI serial cards */
+       { PCI_DEVICE(0x1c29, 0x1104), .driver_data = pbn_fintek_4 },
+       { PCI_DEVICE(0x1c29, 0x1108), .driver_data = pbn_fintek_8 },
index f88cc69ed993e4b150ede69d0117356475d1665e..e8a997fbd41195bd6213ac923e7062ab6a7d827b 100644 (file)
@@ -88,3 +88,5 @@ i2c-i801-fix-resume-bug.patch
 percpu-fix-first-chunk-size-calculation-for-populated-bitmap.patch
 input-trackpoint-add-new-trackpoint-variant-ids.patch
 input-i8042-add-entroware-proteus-el07r4-to-nomux-and-reset-lists.patch
+thunderbolt-retry-drom-read-once-if-parsing-fails.patch
+serial-8250_pci-add-realtek-816a-and-816b.patch
diff --git a/queue-4.14/thunderbolt-retry-drom-read-once-if-parsing-fails.patch b/queue-4.14/thunderbolt-retry-drom-read-once-if-parsing-fails.patch
new file mode 100644 (file)
index 0000000..1db8340
--- /dev/null
@@ -0,0 +1,77 @@
+From f022ff7bf377ca94367be05de61277934d42ea74 Mon Sep 17 00:00:00 2001
+From: Mika Westerberg <mika.westerberg@linux.intel.com>
+Date: Mon, 7 Sep 2020 12:20:36 +0300
+Subject: thunderbolt: Retry DROM read once if parsing fails
+
+From: Mika Westerberg <mika.westerberg@linux.intel.com>
+
+commit f022ff7bf377ca94367be05de61277934d42ea74 upstream.
+
+Kai-Heng reported that sometimes DROM parsing of ASUS PA27AC Thunderbolt 3
+monitor fails. This makes the driver to fail to add the device so only
+DisplayPort tunneling is functional.
+
+It is not clear what exactly happens but waiting for 100 ms and retrying
+the read seems to work this around so we do that here.
+
+Link: https://bugzilla.kernel.org/show_bug.cgi?id=206493
+Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
+Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/thunderbolt/eeprom.c |   20 ++++++++++++++++----
+ 1 file changed, 16 insertions(+), 4 deletions(-)
+
+--- a/drivers/thunderbolt/eeprom.c
++++ b/drivers/thunderbolt/eeprom.c
+@@ -6,6 +6,7 @@
+  */
+ #include <linux/crc32.h>
++#include <linux/delay.h>
+ #include <linux/property.h>
+ #include <linux/slab.h>
+ #include "tb.h"
+@@ -385,8 +386,8 @@ static int tb_drom_parse_entries(struct
+               struct tb_drom_entry_header *entry = (void *) (sw->drom + pos);
+               if (pos + 1 == drom_size || pos + entry->len > drom_size
+                               || !entry->len) {
+-                      tb_sw_warn(sw, "drom buffer overrun, aborting\n");
+-                      return -EIO;
++                      tb_sw_warn(sw, "DROM buffer overrun\n");
++                      return -EILSEQ;
+               }
+               switch (entry->type) {
+@@ -492,7 +493,8 @@ int tb_drom_read(struct tb_switch *sw)
+       u16 size;
+       u32 crc;
+       struct tb_drom_header *header;
+-      int res;
++      int res, retries = 1;
++
+       if (sw->drom)
+               return 0;
+@@ -584,7 +586,17 @@ parse:
+               tb_sw_warn(sw, "drom device_rom_revision %#x unknown\n",
+                       header->device_rom_revision);
+-      return tb_drom_parse_entries(sw);
++      res = tb_drom_parse_entries(sw);
++      /* If the DROM parsing fails, wait a moment and retry once */
++      if (res == -EILSEQ && retries--) {
++              tb_sw_warn(sw, "parsing DROM failed, retrying\n");
++              msleep(100);
++              res = tb_drom_read_n(sw, 0, sw->drom, size);
++              if (!res)
++                      goto parse;
++      }
++
++      return res;
+ err:
+       kfree(sw->drom);
+       sw->drom = NULL;