]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
remoteproc: omap: Simplify returning syscon PTR_ERR
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 11 Jan 2025 18:42:50 +0000 (19:42 +0100)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Wed, 15 Jan 2025 16:51:47 +0000 (09:51 -0700)
No need to store PTR_ERR into temporary, local 'ret' variable.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250111-b4-syscon-phandle-args-remoteproc-v1-2-73ed6fafa1e3@linaro.org
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/omap_remoteproc.c

index 3260dd512491e8920fc881b6a7c0d9b6f725e7f5..5f463937cbbff2c9ed5b22bed42454a0ae290f0f 100644 (file)
@@ -1137,7 +1137,6 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev,
        struct device_node *np = pdev->dev.of_node;
        struct omap_rproc *oproc = rproc->priv;
        const struct omap_rproc_dev_data *data;
-       int ret;
 
        data = of_device_get_match_data(&pdev->dev);
        if (!data)
@@ -1153,10 +1152,8 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev,
 
        oproc->boot_data->syscon =
                        syscon_regmap_lookup_by_phandle(np, "ti,bootreg");
-       if (IS_ERR(oproc->boot_data->syscon)) {
-               ret = PTR_ERR(oproc->boot_data->syscon);
-               return ret;
-       }
+       if (IS_ERR(oproc->boot_data->syscon))
+               return PTR_ERR(oproc->boot_data->syscon);
 
        if (of_property_read_u32_index(np, "ti,bootreg", 1,
                                       &oproc->boot_data->boot_reg)) {