]> git.ipfire.org Git - pakfire.git/commitdiff
libpakfire: Make return code of pakfire_paclkage_is_cached() clearer
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 16 Feb 2018 15:39:59 +0000 (16:39 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 16 Feb 2018 15:39:59 +0000 (16:39 +0100)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/libpakfire/package.c
src/libpakfire/step.c

index 47b304673e115d510ebeddd4a589984f2698bed3..9f3ea6e5226c689d749bd367686eb9b55e7c73de 100644 (file)
@@ -865,7 +865,7 @@ PAKFIRE_EXPORT int pakfire_package_is_cached(PakfirePackage pkg) {
        int r = pakfire_access(path, NULL, R_OK);
        pakfire_free(path);
 
-       return r;
+       return (r == 0);
 }
 
 PAKFIRE_EXPORT char* pakfire_package_get_cache_path(PakfirePackage pkg) {
index 6d392b5ed591c05ce2d22d0596d76533ff1afa27..f3df4b9b9d665d211496471910fe12e71864d855 100644 (file)
@@ -207,7 +207,7 @@ PAKFIRE_EXPORT int pakfire_step_needs_download(PakfireStep step) {
                return false;
 
        // Return false if package is in cache.
-       if (pakfire_package_is_cached(step->package) == 0)
+       if (pakfire_package_is_cached(step->package))
                return false;
 
        return true;