5.10-stable patches

added patches:
	can-mcp251xfd-mcp251xfd_remove-fix-order-of-unregistration-calls.patch

diff --git a/queue-5.10/can-mcp251xfd-mcp251xfd_remove-fix-order-of-unregistration-calls.patch b/queue-5.10/can-mcp251xfd-mcp251xfd_remove-fix-order-of-unregistration-calls.patch
new file mode 100644 (file)
index 0000000..e243d3f
--- /dev/null
+++ b/queue-5.10/can-mcp251xfd-mcp251xfd_remove-fix-order-of-unregistration-calls.patch
@@ -0,0 +1,47 @@
+From 84f5eb833f53ae192baed4cfb8d9eaab43481fc9 Mon Sep 17 00:00:00 2001
+From: Marc Kleine-Budde <mkl@pengutronix.de>
+Date: Fri, 2 May 2025 16:13:44 +0200
+Subject: can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls
+
+From: Marc Kleine-Budde <mkl@pengutronix.de>
+
+commit 84f5eb833f53ae192baed4cfb8d9eaab43481fc9 upstream.
+
+If a driver is removed, the driver framework invokes the driver's
+remove callback. A CAN driver's remove function calls
+unregister_candev(), which calls net_device_ops::ndo_stop further down
+in the call stack for interfaces which are in the "up" state.
+
+With the mcp251xfd driver the removal of the module causes the
+following warning:
+
+| WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8
+
+as can_rx_offload_del() deletes the NAPI, while it is still active,
+because the interface is still up.
+
+To fix the warning, first unregister the network interface, which
+calls net_device_ops::ndo_stop, which disables the NAPI, and then call
+can_rx_offload_del().
+
+Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
+Cc: stable@vger.kernel.org
+Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-1-59a9b131589d@pengutronix.de
+Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
++++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
+@@ -2889,8 +2889,8 @@ static int mcp251xfd_remove(struct spi_d
+       struct mcp251xfd_priv *priv = spi_get_drvdata(spi);
+       struct net_device *ndev = priv->ndev;
+ 
+-      can_rx_offload_del(&priv->offload);
+       mcp251xfd_unregister(priv);
++      can_rx_offload_del(&priv->offload);
+       spi->max_speed_hz = priv->spi_max_speed_hz_orig;
+       free_candev(ndev);
+ 

diff --git a/queue-5.10/series b/queue-5.10/series
index 95f7237e19a9f7a969e84440a62853b031789a51..1e4b5122a1c00de1db104108f81df4f05595d0f7 100644 (file)
--- a/queue-5.10/series
+++ b/queue-5.10/series
@@ -39,3 +39,4 @@ usb-chipidea-ci_hdrc_imx-use-dev_err_probe.patch
 usb-chipidea-ci_hdrc_imx-implement-usb_phy_init-erro.patch
 dm-fix-copying-after-src-array-boundaries.patch
 scsi-target-fix-write_same-no-data-buffer-crash.patch
+can-mcp251xfd-mcp251xfd_remove-fix-order-of-unregistration-calls.patch