]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
dco_linux: properly close dco version file
authorFrank Lichtenheld <frank@lichtenheld.com>
Fri, 12 May 2023 15:50:23 +0000 (17:50 +0200)
committerGert Doering <gert@greenie.muc.de>
Sat, 13 May 2023 09:09:46 +0000 (11:09 +0200)
Since we only call this once, it is not a bad
leak, but still.

Change-Id: Id85766738c3ece4f2d1860f7d101e4446a894aed
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230512155023.444406-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26650.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/dco_linux.c

index 41540c0f8c2dc7a79e837c30018820beb1060f0e..796e6f25da4b4ffd72f5124a6048ec710e604a40 100644 (file)
@@ -1020,6 +1020,7 @@ dco_version_string(struct gc_arena *gc)
 
     if (!fgets(BSTR(&out), BCAP(&out), fp))
     {
+        fclose(fp);
         return "ERR";
     }
 
@@ -1031,6 +1032,7 @@ dco_version_string(struct gc_arena *gc)
         *nl = '\0';
     }
 
+    fclose(fp);
     return BSTR(&out);
 }