]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
f2fs: don't call block truncation for aliased file
authorJaegeuk Kim <jaegeuk@kernel.org>
Tue, 7 Jan 2025 02:26:34 +0000 (02:26 +0000)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 8 Jan 2025 18:31:45 +0000 (18:31 +0000)
This patch should avoid the below warning which does not corrupt the metadata
tho.

[   51.508120][  T253] F2FS-fs (dm-59): access invalid blkaddr:36
[   51.508156][  T253]  __f2fs_is_valid_blkaddr+0x330/0x384
[   51.508162][  T253]  f2fs_is_valid_blkaddr_raw+0x10/0x24
[   51.508163][  T253]  f2fs_truncate_data_blocks_range+0x1ec/0x438
[   51.508177][  T253]  f2fs_remove_inode_page+0x8c/0x148
[   51.508194][  T253]  f2fs_evict_inode+0x230/0x76c

Fixes: 128d333f0dff ("f2fs: introduce device aliasing file")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/node.c

index c04ee1a7ce57e1241f38d49775248b514e8497a1..00f340c91fcbe7ad570831446d9685e32de46850 100644 (file)
@@ -1275,8 +1275,9 @@ int f2fs_remove_inode_page(struct inode *inode)
        }
 
        /* remove potential inline_data blocks */
-       if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
-                               S_ISLNK(inode->i_mode))
+       if (!IS_DEVICE_ALIASING(inode) &&
+           (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
+            S_ISLNK(inode->i_mode)))
                f2fs_truncate_data_blocks_range(&dn, 1);
 
        /* 0 is possible, after f2fs_new_inode() has failed */