]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c: Fix warning after an error on a return statment [PR60440]
authorAndrew Pinski <quic_apinski@quicinc.com>
Fri, 7 Mar 2025 00:07:02 +0000 (16:07 -0800)
committerAndrew Pinski <quic_apinski@quicinc.com>
Fri, 7 Mar 2025 18:00:06 +0000 (18:00 +0000)
Like r5-6912-g3dbb84276aca10 but this is for the C front-end.
Basically we have an error on a return statement, we just return
error_mark_node and then the warning happens as there is no return
statement. Anyways instead mark the current function for supression
of the warning instead.

PR c/60440

gcc/c/ChangeLog:

* c-typeck.cc (c_finish_return): Mark the current function
for supression of the -Wreturn-type if there was an error
on the return statement.

gcc/testsuite/ChangeLog:

* gcc.dg/Wreturn-mismatch-2.c: Change dg-warning
for the last -Wreturn-type to dg-bogus.
* gcc.dg/pr60440-1.c: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
gcc/c/c-typeck.cc
gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c
gcc/testsuite/gcc.dg/pr60440-1.c [new file with mode: 0644]

index 691b583db3f85eeb5d640711b797c6756dfa890d..a13989a6607662d6ce16a21bb804d6e6abbac304 100644 (file)
@@ -12765,7 +12765,12 @@ c_finish_return (location_t loc, tree retval, tree origtype, bool musttail_p)
 
       current_function_returns_value = 1;
       if (t == error_mark_node)
-       return NULL_TREE;
+       {
+         /* Suppress -Wreturn-type for this function.  */
+         if (warn_return_type)
+           suppress_warning (current_function_decl, OPT_Wreturn_type);
+         return NULL_TREE;
+       }
 
       save = in_late_binary_op;
       if (C_BOOLEAN_TYPE_P (TREE_TYPE (res))
index 08811024b7e52cdcaad90c7e73bbcb35629532ad..52852261a0d62b9fdab08b7a932bc90e26f1dd75 100644 (file)
@@ -37,5 +37,5 @@ int
 f7 (void)
 {
   return f1 (); /* { dg-error "void value not ignored as it ought to be" } */
-} /* { dg-warning "control reaches end of non-void\[^\n\r\]*-Wreturn-type" } */
+} /* { dg-bogus "control reaches end of non-void\[^\n\r\]*-Wreturn-type" } */
 
diff --git a/gcc/testsuite/gcc.dg/pr60440-1.c b/gcc/testsuite/gcc.dg/pr60440-1.c
new file mode 100644 (file)
index 0000000..cd179cf
--- /dev/null
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options "-Wreturn-type" } */
+
+/* PR c/60440 */
+/* Don't warn for a missing return when there was an error
+   on the return stamtent. */
+
+int f(int a) {
+  return a + b; /* { dg-error "undeclared" } */
+} /* { dg-bogus "control reaches end of non-void function" } */